Possible bug, need second opinion

[katsklaw]

A user of mine pointed out this possible bug.

on initial connection the ircd sends the luser count and in it they and I both see:

Code: Select all

I have 64 clients and 0 servers

Notice the 0 servers, I first encountered this on my modified Unreal.3.2.8.1 which is no good for reporting bugs. So I went around to several other Unreal nets and seen the same thing. In all but one case a /lusers command would reply with the actual count for servers and I have 1 case of 3.2.7 that still reports 0 servers.

Has anyone else seen this?

[Syzop]

And what should the value be?
I mean, if you have no servers linked, then it will show 'I have ... 0 servers', and a few lines above it should show 'There are ... on 1 servers'.
I guess I'm just saying 0 isn't always incorrect, it doesn't count itself in the 'I have .. servers' (as that would be incorrect).
I did a quick test by simply linking & squiting to see if the values were correct, and they are.
Of course, if you have a mismatch, then it's a bug, which may be reported

[katsklaw]

Lets look at it like this. I can't always reproduce the "bug", which is why I'm asking for second opinions. ;)

:: on connect ::
Unreal3.2.7. Chicago.IL.US.ChatNet.Org FinXeOoZE [*=2309]
-
<- :Chicago.IL.US.ChatNet.Org 005 Praetorian INVEX :are supported by this server
<- :Chicago.IL.US.ChatNet.Org 251 Praetorian :There are 10 users and 141 invisible on 6 servers
<- :Chicago.IL.US.ChatNet.Org 252 Praetorian 11 :operator(s) online
<- :Chicago.IL.US.ChatNet.Org 254 Praetorian 123 :channels formed
<- :Chicago.IL.US.ChatNet.Org 255 Praetorian :I have 60 clients and 0 servers
<- :Chicago.IL.US.ChatNet.Org 265 Praetorian :Current Local Users: 60 Max: 217
<- :Chicago.IL.US.ChatNet.Org 266 Praetorian :Current Global Users: 151 Max: 935
<- :Chicago.IL.US.ChatNet.Org 375 Praetorian :- Chicago.IL.US.ChatNet.Org Message of the Day -
-

:: /map ::
-
Chicago.IL.US.ChatNet.Org (59) 2
|-GrandRapids.MI.US.ChatNet.Org (15) 14
|-MapleLeaf.ON.CA.ChatNet.Org (9) 15
|-NewYork.NY.US.ChatNet.Org (2) 1
`-Sydney.NSW.AU.ChatNet.Org (55) 22
End of /MAP


:: /lusers ::
<- :Chicago.IL.US.ChatNet.Org 251 Praetorian :There are 9 users and 142 invisible on 6 servers
<- :Chicago.IL.US.ChatNet.Org 252 Praetorian 11 :operator(s) online
<- :Chicago.IL.US.ChatNet.Org 254 Praetorian 123 :channels formed
<- :Chicago.IL.US.ChatNet.Org 255 Praetorian :I have 60 clients and 0 servers
<- :Chicago.IL.US.ChatNet.Org 265 Praetorian :Current Local Users: 60 Max: 217
<- :Chicago.IL.US.ChatNet.Org 266 Praetorian :Current Global Users: 151 Max: 935

:: on conect ::

<- :prozac.fr.nite-serv.com 351 Praetorian Unreal3.2.8.1. prozac.fr.nite-serv.com :FhinXeOoZEM3 [*=2309]

-
<- :prozac.fr.nite-serv.com 005 Praetorian STATUSMSG=~&@%+ EXCEPTS INVEX :are supported by this server
<- :prozac.fr.nite-serv.com 251 Praetorian :There are 25 users and 138 invisible on 14 servers
<- :prozac.fr.nite-serv.com 252 Praetorian 28 :operator(s) online
<- :prozac.fr.nite-serv.com 254 Praetorian 71 :channels formed
<- :prozac.fr.nite-serv.com 255 Praetorian :I have 14 clients and 0 servers
<- :prozac.fr.nite-serv.com 265 Praetorian :Current Local Users: 14 Max: 22
<- :prozac.fr.nite-serv.com 266 Praetorian :Current Global Users: 163 Max: 1276
<- :prozac.fr.nite-serv.com 422 Praetorian :MOTD File is missing

:: /map ::

-> prozac.fr.nite-serv.com MAP
<- :prozac.fr.nite-serv.com 006 Praetorian :prozac.fr.nite-serv.com (14) 4
<- :prozac.fr.nite-serv.com 006 Praetorian :|-st0rm.janus (75) 42
<- :prozac.fr.nite-serv.com 006 Praetorian :|-goc.ky.us.nite-serv.com (3) 5
<- :prozac.fr.nite-serv.com 006 Praetorian :|-mp.janus (16) 41
<- :prozac.fr.nite-serv.com 006 Praetorian :|-irc.kamuix.com (16) 6
<- :prozac.fr.nite-serv.com 006 Praetorian :|-cloudzone.nite-serv.com (9) 9
<- :prozac.fr.nite-serv.com 006 Praetorian :|-irc.Frag-Force.net (2) 10
<- :prozac.fr.nite-serv.com 006 Praetorian :|-ascendedwarriors.nite-serv.com (1) 7
<- :prozac.fr.nite-serv.com 006 Praetorian :|-irc.fwclan.co.uk (0) 12
<- :prozac.fr.nite-serv.com 006 Praetorian :|-hub.janus (1) 40
<- :prozac.fr.nite-serv.com 006 Praetorian :|-hub.tx.us.nite-serv.com (1) 17
<- :prozac.fr.nite-serv.com 006 Praetorian :`-hub.fr.nite-serv.com (2) 1
<- :prozac.fr.nite-serv.com 007 Praetorian :End of /MAP

:: /lusers ::

-> prozac.fr.nite-serv.com LUSERS
<- :prozac.fr.nite-serv.com 251 Praetorian :There are 24 users and 139 invisible on 14 servers
<- :prozac.fr.nite-serv.com 252 Praetorian 28 :operator(s) online
<- :prozac.fr.nite-serv.com 254 Praetorian 71 :channels formed
<- :prozac.fr.nite-serv.com 255 Praetorian :I have 14 clients and 0 servers
<- :prozac.fr.nite-serv.com 265 Praetorian :Current Local Users: 14 Max: 22
<- :prozac.fr.nite-serv.com 266 Praetorian :Current Global Users: 163 Max: 1276



But this one is working correctly:

-> amsterdam.nl.vision-irc.net VERSION
<- :amsterdam.nl.vision-irc.net 351 Praetorian Unreal3.2.8.1. amsterdam.nl.vision-irc.net :FhinXeOoZE3 [*=2309]

<- :amsterdam.nl.vision-irc.net 251 Praetorian :There are 16 users and 129 invisible on 4 servers
<- :amsterdam.nl.vision-irc.net 252 Praetorian 13 :operator(s) online
<- :amsterdam.nl.vision-irc.net 254 Praetorian 49 :channels formed
<- :amsterdam.nl.vision-irc.net 255 Praetorian :I have 64 clients and 3 servers
<- :amsterdam.nl.vision-irc.net 265 Praetorian :Current Local Users: 64 Max: 97
<- :amsterdam.nl.vision-irc.net 266 Praetorian :Current Global Users: 145 Max: 449
<- :amsterdam.nl.vision-irc.net 375 Praetorian :- amsterdam.nl.vision-irc.net Message of the Day -

-> amsterdam.nl.vision-irc.net LINKS
<- :amsterdam.nl.vision-irc.net 364 Praetorian miami.us.vision-irc.net amsterdam.nl.vision-irc.net :1 Provided by Chimp
<- :amsterdam.nl.vision-irc.net 364 Praetorian maidenhead.uk.vision-irc.net amsterdam.nl.vision-irc.net :1 Provided by Beef
<- :amsterdam.nl.vision-irc.net 364 Praetorian services.vision-irc.net amsterdam.nl.vision-irc.net :1 Services for ViSiON-iRC
<- :amsterdam.nl.vision-irc.net 364 Praetorian amsterdam.nl.vision-irc.net amsterdam.nl.vision-irc.net :0 Provided by FriedCPU
<- :amsterdam.nl.vision-irc.net 365 Praetorian * :End of /LINKS list.
-> amsterdam.nl.vision-irc.net LUSERS

<- :amsterdam.nl.vision-irc.net 251 Praetorian :There are 15 users and 130 invisible on 4 servers
<- :amsterdam.nl.vision-irc.net 252 Praetorian 13 :operator(s) online
<- :amsterdam.nl.vision-irc.net 254 Praetorian 49 :channels formed
<- :amsterdam.nl.vision-irc.net 255 Praetorian :I have 64 clients and 3 servers
<- :amsterdam.nl.vision-irc.net 265 Praetorian :Current Local Users: 64 Max: 97
<- :amsterdam.nl.vision-irc.net 266 Praetorian :Current Global Users: 145 Max: 449

[Jobe]

Just a guess but the difference could be caused by the direction of the server connection. I mean the number of clients it says it has is the number of client connections that connected to the server, so it's possible the server count in the same line means the same but for servers.

EDIT:
having looked at the source I can explain the 0 with the following code:

Code: Select all

flatmap = (FLAT_MAP && !IsAnOper(sptr)) ? 1 : 0;

sendto_one(sptr, rpl_str(RPL_LUSERME), me.name, parv[0], IRCstats.me_clients, flatmap ? 0 : IRCstats.me_servers);

Also after a couple of quick greps IRCstats.me_servers is only incremented in one place where IRCstats.servers is incremented in 2 places. Having looked further it appears my previous theory is correct about the difference being caused by the connection direction and is apparently intentional.

[katsklaw]

ok, that makes sense. so it seem it's part of flatmap. I don't see the reason for hiding server count though, just topology. I mean I fail to see how knowing the number of servers in lusers for non-opers is a threat when /map will display them all anyway.

EDIT: The reason it's showing 0 on connect but not in /lusers is because in the interim both I and this other person are opering, thus showing the real count. So I guess we are done here.