Deny version not working?

[aquanight]

Maybe I'm doing something wrong. Maybe it's a bug. I dunno. But when I try to use deny version, a server matching both conditions can still connect.

I tested this with telnet, since I don't have a 3.2 IRCd laying around, so here's what I sent:

Code: Select all

PASS :<removed>
PROTOCTL VL
SERVER services.<removed> 1 :U2303-O

(BTW, the O after the dash might look like a 0, but it is most certainly an O . Silly strange monospace font .)

The deny version I have is:

Code: Select all

deny version {
	mask "*";
	version <2304;
	flags "XneZE!O!C!D!K!6";
};

And ...

Code: Select all

V <2304 XneZE!O!C!D!K!6 *
End of /STATS report
[15:51:42] -irc.<removed>- Stats 'v' requested by aquanight (aquanight@netadmin.<removed>)

When I did my thing, the connection succeeded! Even flipping the !s around it succeeded (with the same text sent).

I've tried other things like sending PROTOCTL first, sending PROTOCTL with a : in front of the tokens. As I said, I don't have a real IRCd I need to test with, so I'm working off telnet :/ .

Of course, I could be doing something wrong.

Also, is deny version::flags and deny version::version an "either or" match (fails one gets dropped), or a "must match both" match (must fail both to be dropped).

[codemastr]

I would suggest trying it with an actual IRCd.

[aquanight]

Well I would, but to test the protocol < 2304 would require an older IRCd which is no longer available... which of course would make compiling an ircd locally pointless if both conditions must occur to deny a server, and I don't know anyone with a 3.2 or earlier server...

Just to try something though, I'm gonna try compiling an ircd with operoverride enabled and link it. The flags field should cause it to drop if it's either-or...

*edit* scrub debugmode, that generated a compile error maybe I'll post that on bugs.* later */edit*

[aquanight]

Ok, after finally sorting out configs, ssl, fun stuff...

Code: Select all

[01:28:30] -test.<removed>- *** Connecting to irc.<removed>[127.0.0.1].
* Identd request from 127.0.0.1
* Identd replied: 2467, 6667 : USERID : UNIX : aquanight
* Identd request from 127.0.0.1
* Identd replied: 6667, 2467 : USERID : UNIX : aquanight
[01:28:31] -test.<removed>- *** LocOps -- ERROR :from irc.<removed>[127.0.0.1] -- Closing Link: test.<removed>[127.0.0.1] (Denied by V:line)
[01:28:31] -test.<removed>- *** LocOps -- Server irc.<removed>[127.0.0.1] closed the connection

Strange that telnetting it didn't work... isn't it the same protocol?

Oh well... at least it works for a real ircd, and answers my question about wither version/flags are and or or matching .

*edit* Maybe I'll put this on bugs.* but shouldn't the receiving server send a notice with extra details concerning the denied link? I was on both servers (under different nicks) and saw no message from the irc.* . */edit*